Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error to PriceFeedMock #1

Closed
wants to merge 1 commit into from
Closed

Conversation

0xAkuti
Copy link
Owner

@0xAkuti 0xAkuti commented Nov 7, 2024

Adds missing error definition for the error LZ_PriceFeed_NotAnOPStack which is used in PriceFeedMock._getL1LookupId() and currently causing issues (LayerZero-Labs#978).

Error: 
Compiler run failed:
Error (7576): Undeclared identifier.
   --> lib/devtools/packages/test-devtools-evm-foundry/contracts/mocks/PriceFeedMock.sol:184:16:
    |
184 |         revert LZ_PriceFeed_NotAnOPStack(l2Eid);
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^

The alternative would be to add it in ILayerZeroPriceFeed where the error LZ_PriceFeed_UnknownL2Eid which was previously used is defined, but since LZ_PriceFeed_NotAnOPStack seems to only be used in this mock and not in layerzero v2 adding it here seems to be the way to go.

@0xAkuti 0xAkuti closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant