Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates #693

Merged
merged 1 commit into from
Sep 3, 2024
Merged

minor updates #693

merged 1 commit into from
Sep 3, 2024

Conversation

stormcloud266
Copy link
Collaborator

@stormcloud266 stormcloud266 commented Aug 31, 2024

Knocks out a few smol changes that were requested:

  • Decrease this space below the Send logo and menu. Cut it in half
  • remove notifications, security, privacy from settings
  • Fix alignment on subtext rewards page

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stormcloud266 and the rest of your teammates on Graphite Graphite

@stormcloud266 stormcloud266 marked this pull request as ready for review August 31, 2024 03:09
Copy link
Collaborator

@youngkidwarrior youngkidwarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple lil things

@stormcloud266 stormcloud266 force-pushed the 08-30-minor_updates branch 2 times, most recently from c76b4af to 0ea9928 Compare August 31, 2024 03:15
Copy link

Vercel Unique URL: https://sendapp-ath2mcelr-0xsend.vercel.app
Vercel Preview URL: sendapp-08-30-minor-updates-0xsend.vercel.app
Last Commit: 42c97fe

Copy link

Playwright Report

Summary

Expected Skipped Unexpected Flaky Duration
82 0 0 8 117.17s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

  • chromium: ✅
  • firefox: ✅

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

  • chromium: ✅
  • firefox: ✅

can add a pending tag

  • chromium: ✅
  • firefox: ✅

cannot add an invalid tag name

  • chromium: ✅
  • firefox: ✅

can confirm a tag

  • chromium: ✅
  • firefox: ✅

can refer a tag

  • chromium: ✅
  • firefox: 🚨

can refer multiple tags in separate transactions

  • chromium: ✅
  • firefox: ✅

cannot confirm a tag without paying

  • chromium: ✅
  • firefox: ✅

cannot add more than 5 tags

  • chromium: ✅
  • firefox: ✅

account-settings-backup.onboarded.spec.ts

can backup account

  • chromium: ✅
  • firefox: ✅

can remove a signer

  • chromium: ✅
  • firefox: ✅

account.logged-in.spec.ts

can visit account page

  • chromium: ✅
  • firefox: ✅

can update profile

  • chromium: ✅
  • firefox: ✅

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

  • chromium: ✅
  • firefox: ✅

can search on activity page

  • chromium: ✅
  • firefox: ✅

deposit.onboarded.spec.ts

can deposit USDC with web3 wallet

  • chromium: ✅
  • firefox: ✅

can deposit ETH with web3 wallet

  • chromium: ✅
  • firefox: ✅

can connect and disconnect using wallet button

  • chromium: ✅
  • firefox: ✅

must switch to supported network

  • chromium: ✅
  • firefox: ✅

home.onboarded.spec.ts

can visit token detail page

  • chromium: ✅
  • firefox: 🚨

leaderboard.logged-in.spec.ts

can visit leaderboard page

  • chromium: ✅
  • firefox: ✅

onboarding.logged-in.spec.ts

can visit onboarding page

  • chromium: ✅
  • firefox: ✅

profile.anon.spec.ts

anon user can visit public profile

  • chromium: ✅
  • firefox: ✅

anon user cannot visit private profile

  • chromium: ✅
  • firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

  • chromium: ✅
  • firefox: ✅

profile.onboarded.spec.ts

can visit other user profile and send by tag

  • chromium: ✅
  • firefox: ✅

can visit my own profile

  • chromium: ✅
  • firefox: ✅

can visit private profile

  • chromium: ✅
  • firefox: ✅

can view activities between another profile

  • chromium: ✅
  • firefox: ✅

send.onboarded.spec.ts

can send USDC starting from profile page

  • chromium: ✅
  • firefox: ✅

can send USDC using tag starting from home page

  • chromium: ✅
  • firefox: ✅

can send USDC using sendid starting from home page

  • chromium: ✅
  • firefox: ✅

can send USDC using address starting from home page

  • chromium: ✅
  • firefox: 🚨

can send ETH starting from profile page

  • chromium: ✅
  • firefox: 🚨

can send ETH using tag starting from home page

  • chromium: 🚨
  • firefox: ✅

can send ETH using sendid starting from home page

  • chromium: ✅
  • firefox: ✅

can send ETH using address starting from home page

  • chromium: 🚨
  • firefox: ✅

can send SEND starting from profile page

  • chromium: ✅
  • firefox: ✅

can send SEND using tag starting from home page

  • chromium: 🚨
  • firefox: ✅

can send SEND using sendid starting from home page

  • chromium: ✅
  • firefox: ✅

can send SEND using address starting from home page

  • chromium: ✅
  • firefox: 🚨

sign-in.anon.spec.ts

redirect on sign-in

  • chromium: ✅
  • firefox: ✅

redirect to send confirm page on sign-in

  • chromium: ✅
  • firefox: ✅

sign-up.anon.spec.ts

can sign up

  • chromium: ✅
  • firefox: ✅

country code is selected based on geoip

  • chromium: ✅
  • firefox: ✅

Copy link
Collaborator

youngkidwarrior commented Sep 3, 2024

Merge activity

@youngkidwarrior youngkidwarrior merged commit d0c180c into dev Sep 3, 2024
8 checks passed
@youngkidwarrior youngkidwarrior deleted the 08-30-minor_updates branch September 3, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants