Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the add_new and add_new_item labels are the same #404

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Nov 12, 2024

Description of the Change

In testing on WP 6.7, the Add New button for the Safe Redirect Manager post type is showing as Safe Redirect Manager instead of Create Redirect Rule. This causes an E2E failure and also doesn't make much sense, since this button shows right next to the title which is also Safe Redirect Manager.

Seems WP 6.7 changed something around the add_new and add_new_item labels so this PR ensures our post type uses the same text for both.

Before on WP 6.7:

Settings page before fix

After on WP 6.7 (and older):

Settings page after fix

How to test the Change

  1. Go to the Safe Redirect Manager page under Tools
  2. Ensure the button shown at the top says Create Redirect Rule
  3. Test on both WP 6.7 and 6.6

Changelog Entry

Fixed - Ensure the add new button shows proper text

Credits

Props @dkotter, @jeffpaul

Checklist:

@dkotter dkotter added this to the 2.3.0 milestone Nov 12, 2024
@dkotter dkotter self-assigned this Nov 12, 2024
@dkotter dkotter requested a review from jeffpaul as a code owner November 12, 2024 19:55
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 12, 2024
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting on e2e tests to pass before merging

@jeffpaul jeffpaul merged commit 6a683db into develop Nov 12, 2024
17 checks passed
@jeffpaul jeffpaul deleted the fix/post-type-label branch November 12, 2024 20:08
@jeffpaul jeffpaul modified the milestones: 2.3.0, 2.2.1 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants