Skip to content

Commit

Permalink
debug: try to declare implicit artifacts of github release
Browse files Browse the repository at this point in the history
  • Loading branch information
2BAB committed Dec 27, 2023
1 parent 46a0650 commit 24d092f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 17 deletions.
20 changes: 5 additions & 15 deletions buildSrc/src/main/kotlin/github-release.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -46,20 +46,10 @@ fun createGithubReleaseTaskInternal(
dryRun.set(false)
generateReleaseNotes.set(false)
releaseAssets.from(
tasks.getByName<Jar>("jar")
.destinationDirectory
.map { it.asFile.listFiles() }
tasks.getByName<Jar>("jar").archiveFile, // seal-${version}.jar
tasks.getByName<Jar>("sourcesJar").archiveFile, // seal-${version}-sources.jar
tasks.getByName<Jar>("javadocJar").archiveFile, // seal-${version}-javadoc.jar
//tasks.getByName<Sign>("signPluginMavenPublication").outputs, // seal-${version}-asc.jar, seal-${version}-sources-asc.jar, seal-${version}-sources-asc.jar,
)
// By right we should put all explicit artifacts,
// however those artifacts does not have APIs to
// be fetched obviously. Thus we put a lot of
// `dependesOn()` below and keep here as a folder.
}
}

task.configure {
dependsOn(tasks.findByPath("signPluginMavenPublication"))
dependsOn(tasks.findByPath("sourcesJar"))
dependsOn(tasks.findByPath("javadocJar"))
dependsOn(tasks.findByPath("jar"))
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class SealBaseFunctionTest {
println("assembleFullDebug for [$agpVer]")

GradleRunner.create()
.withGradleVersion("8.1.1")
.withGradleVersion("8.5")
.forwardOutput()
.withArguments("clean", "assembleDebug", "--stacktrace", "--scan")
.withProjectDir(targetProject)
Expand Down
2 changes: 1 addition & 1 deletion publish.sh
Original file line number Diff line number Diff line change
@@ -1 +1 @@
./gradlew clean :seal:publishPluginMavenPublicationToSonatypeRepository :seal:publishSealPluginMarkerMavenPublicationToSonatypeRepository releaseArtifactsToGithub -s
./gradlew clean :seal:publishPluginMavenPublicationToSonatypeRepository :seal:publishSealPluginMarkerMavenPublicationToSonatypeRepository :seal:releaseArtifactsToGithub -s

0 comments on commit 24d092f

Please sign in to comment.