🔨 [Refactoring] Agenda History 조회시 CONFIRM 상태 추가 #988 (#990)

42organization · Aug 30, 2024 · b6da492 · b6da492
1 parent bf81695
commit b6da492
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/gg-agenda-api/src/main/java/gg/agenda/api/user/agenda/service/AgendaService.java b/gg-agenda-api/src/main/java/gg/agenda/api/user/agenda/service/AgendaService.java
@@ -96,7 +96,7 @@ public Agenda addAgenda(AgendaCreateReqDto createDto, MultipartFile agendaPoster
 
 	@Transactional(readOnly = true)
 	public Page<Agenda> findHistoryAgendaList(Pageable pageable) {
-		return agendaRepository.findAllByStatusIs(AgendaStatus.FINISH, pageable);
+		return agendaRepository.findAllByStatusIs(AgendaStatus.FINISH, AgendaStatus.CONFIRM, pageable);
 	}
 
 	@Transactional

diff --git a/gg-agenda-api/src/test/java/gg/agenda/api/user/agenda/service/AgendaServiceTest.java b/gg-agenda-api/src/test/java/gg/agenda/api/user/agenda/service/AgendaServiceTest.java
@@ -191,7 +191,8 @@ void getAgendaListHistorySuccess() {
 				.build()
 			));
 			Page<Agenda> agendaPage = new PageImpl<>(agendas.subList(0, 10), pageable, size);
-			when(agendaRepository.findAllByStatusIs(eq(AgendaStatus.FINISH), any(Pageable.class)))
+			when(agendaRepository.findAllByStatusIs(
+				eq(AgendaStatus.FINISH), eq(AgendaStatus.CONFIRM), any(Pageable.class)))
 				.thenReturn(agendaPage);
 
 			// when
@@ -200,7 +201,7 @@ void getAgendaListHistorySuccess() {
 
 			// then
 			verify(agendaRepository, times(1))
-				.findAllByStatusIs(AgendaStatus.FINISH, pageable);
+				.findAllByStatusIs(AgendaStatus.FINISH, AgendaStatus.CONFIRM, pageable);
 			assertThat(result.size()).isEqualTo(size);
 			for (int i = 1; i < result.size(); i++) {
 				assertThat(result.get(i).getStartTime())

diff --git a/gg-repo/src/main/java/gg/repo/agenda/AgendaRepository.java b/gg-repo/src/main/java/gg/repo/agenda/AgendaRepository.java
@@ -20,7 +20,8 @@ public interface AgendaRepository extends JpaRepository<Agenda, Long> {
 	@Query("SELECT a FROM Agenda a WHERE a.status = :status")
 	List<Agenda> findAllByStatusIs(AgendaStatus status);
 
-	Page<Agenda> findAllByStatusIs(AgendaStatus status, Pageable pageable);
+	@Query("SELECT a FROM Agenda a WHERE a.status = :status1 OR a.status = :status2")
+	Page<Agenda> findAllByStatusIs(AgendaStatus status1, AgendaStatus status2, Pageable pageable);
 
 	Optional<Agenda> findAgendaByAgendaKey(UUID usedTo);