✨ [Feature] Admin 공유일정 수정 API 및 테스트 코드 작성 #1059 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1086 +/- ##
============================================
+ Coverage 74.42% 74.51% +0.09%
- Complexity 1227 1230 +3
============================================
Files 399 401 +2
Lines 5524 5545 +21
Branches 440 440
============================================
+ Hits 4111 4132 +21
- Misses 1220 1222 +2
+ Partials 193 191 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wonies
reviewed
Dec 30, 2024
| @@ -240,7 +240,7 @@ public enum ErrorCode { | |||
| CALENDAR_BEFORE_DATE(400, "CA201", "종료 시간이 시작 시간보다 빠를 수 없습니다."), | |||
| CALENDAR_AFTER_DATE(400, "CA202", "시작 시간이 종료 시간보다 늦을 수 없습니다."), | |||
| CALENDAR_EQUAL_DATE(400, "CA203", "시작 시간과 종료 시간이 같을 수 없습니다."), | |||
| CALENDAR_AUTHOR_NOT_MATCH(400, "CA205", "전제하지 않는 사용자입니다."), | |||
| CALENDAR_AUTHOR_NOT_MATCH(400, "CA205", "존제하지 않는 사용자입니다."), | |||
There was a problem hiding this comment.
존재하지 않는 사용자로 바꿔주시기 바랍니다. 😗 403으로 안해주셨던 이유가 있을까요?! git pull 받으셔서 안하신건가요?
taehyeon3
approved these changes
Dec 30, 2024
| public PageResponseDto<PublicScheduleAdminResDto> findAllByClassification( | ||
| DetailClassification detailClassification, int page, int size) { | ||
| public PageResponseDto<PublicScheduleAdminResDto> findAllByClassification(DetailClassification detailClassification, | ||
| int page, int size) { | ||
|
|
||
| Pageable pageable = PageRequest.of(page - 1, size, | ||
| Sort.by(Sort.Order.asc("status"), Sort.Order.asc("startTime"))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
💡Issue 번호