✨ [Feature] 개인일정 수정 api #1057 #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 27, 2024 18:57
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1087 +/- ##
============================================
+ Coverage 74.42% 74.53% +0.11%
- Complexity 1227 1231 +4
============================================
Files 399 401 +2
Lines 5524 5549 +25
Branches 440 440
============================================
+ Hits 4111 4136 +25
Misses 1220 1220
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wonies
approved these changes
Dec 30, 2024
| Assertions.assertThat(privateSchedule.getGroupId()).isEqualTo(scheduleGroup.getId()); | ||
| Assertions.assertThat(privateSchedule.isAlarm()).isEqualTo(reqDto.isAlarm()); | ||
| } | ||
|
|
||
| @Test | ||
| @Transactional | ||
| @DisplayName("일정 그룹이 없는 경우 404") |
There was a problem hiding this comment.
displayname - 404로 쓰신 부분 너무 좋네요. follow하겠습니다.
| scheduleGroup); | ||
| PrivateScheduleUpdateReqDto reqDto = PrivateScheduleUpdateReqDto.builder() | ||
| .eventTag(null) | ||
| .techTag(null) |
There was a problem hiding this comment.
성공하는 로직에서 id가 왜 4인지 아직도 궁금하네요.
seyeon22222
approved these changes
Dec 30, 2024
|
|
||
| @Builder | ||
| public PrivateScheduleUpdateReqDto(EventTag eventTag, JobTag jobTag, TechTag techTag, String title, String content, |
There was a problem hiding this comment.
@builder가 들어간 생성자의 타입을 private으로 통일하기로 해서 수정요청드립니다!
| .header("Authorization", "Bearer " + accessToken) | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| .content(objectMapper.writeValueAsString(reqDto))) | ||
| .andExpect(status().isBadRequest()); |
There was a problem hiding this comment.
테스트에서 에러가 났을 경우, 수정이 안일어났으면 안일어났는지 한번 확인하는건 선택사항일 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💡Issue 번호