Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Admin 공유일정 삭제 API 작성 #1089 #1090

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

seyeon22222
Copy link
Contributor

📌 개요

  • Admin 공유일정 삭제 API 작성했습니다.

💻 작업사항

  • Admin 공유일정 삭제 API 작성했습니다.
  • Admin 공유일정 삭제 API 테스트 코드 작성했습니다.

✅ 변경로직

  • ErrorCode에 이미 삭제된 공유일정입니다 추가했습니다.
  • PublicSchedule에 delete setter함수 추가했습니다.

💡Issue 번호

@seyeon22222 seyeon22222 linked an issue Dec 31, 2024 that may be closed by this pull request
2 tasks
@seyeon22222 seyeon22222 added this to the 8th Sprint 2주차 milestone Dec 31, 2024
@seyeon22222 seyeon22222 self-assigned this Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (a71cfc0) to head (40c27fe).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1090      +/-   ##
============================================
+ Coverage     74.42%   74.54%   +0.12%     
- Complexity     1227     1232       +5     
============================================
  Files           399      401       +2     
  Lines          5524     5552      +28     
  Branches        440      440              
============================================
+ Hits           4111     4139      +28     
  Misses         1220     1220              
  Partials        193      193              
Flag Coverage Δ
integrationTest 69.54% <100.00%> (+0.15%) ⬆️
unitTest 35.82% <33.33%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taehyeon3 taehyeon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wonies wonies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 test code를 꼼꼼하게 잘 적어주신 것 같습니다.
unit test도 기다리고 있겠습니다.

@seyeon22222 seyeon22222 merged commit 93fa00f into dev Dec 31, 2024
5 checks passed
@seyeon22222 seyeon22222 deleted the 1089-feature-admin-페이지-공유일정-삭제-api branch December 31, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Admin 페이지 공유일정 삭제 API
3 participants