Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ [Refactor] ํ† ๋„ˆ๋จผํŠธ์— ๊ฒฝ์šฐ isImminent true๋กœ ์ „๋‹ฌ #442

Conversation

middlefitting
Copy link
Member

@middlefitting middlefitting commented Dec 21, 2023

๐Ÿ“Œ ๊ฐœ์š”

  • ํ˜„์žฌ match ์—”๋“œํฌ์ธํŠธ๋Š” ๊ฒŒ์ž„ ํƒ€์ž… ์ •๋ณด๋ฅผ ์ œ๊ณตํ•ด์ฃผ์ง€ ์•Š์Šต๋‹ˆ๋‹ค. ์ถ”๊ฐ€์ ์ธ ์ •๋ณด ์ œ๊ณต๋ณด๋‹ค๋Š” ํ”„๋ก ํŠธ์—์„œ ํ† ๋„ˆ๋จผํŠธ ๊ฒŒ์ž„์˜ ๊ฒฝ์šฐ๋Š” isImminent๋ฅผ true๋กœ ์ „๋‹ฌํ•  ๊ฒƒ์„ ์š”์ฒญํ•˜์…”์„œ ํ•ด๋‹น ๋‚ด์šฉ์œผ๋กœ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.
  • ์œ ๋‹› ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ž‘์„ฑ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ํ† ๋„ˆ๋จผํŠธ ๊ฒŒ์ž„์˜ ๊ฒฝ์šฐ๋Š” isImminent๋ฅผ true๋กœ ์ „๋‹ฌ

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (76734b6) 68.77% compared to head (173b2e2) 69.34%.
Report is 16 commits behind head on dev.

Files Patch % Lines
...min/tournament/service/TournamentAdminService.java 73.46% 8 Missing and 5 partials โš ๏ธ
...com/gg/server/domain/game/service/GameService.java 18.18% 6 Missing and 3 partials โš ๏ธ
...om/gg/server/domain/match/utils/SlotGenerator.java 0.00% 6 Missing โš ๏ธ
...m/gg/server/domain/match/service/MatchService.java 66.66% 3 Missing and 2 partials โš ๏ธ
...java/com/gg/server/domain/game/GameController.java 66.66% 2 Missing and 1 partial โš ๏ธ
...r/domain/match/service/MatchTournamentService.java 96.15% 1 Missing and 2 partials โš ๏ธ
...gg/server/admin/game/service/GameAdminService.java 50.00% 2 Missing โš ๏ธ
...r/domain/team/exception/TeamNotFoundException.java 0.00% 2 Missing โš ๏ธ
...r/domain/tournament/service/TournamentService.java 84.61% 1 Missing and 1 partial โš ๏ธ
...ent/exception/TournamentGameNotFoundException.java 0.00% 1 Missing โš ๏ธ
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #442      +/-   ##
============================================
+ Coverage     68.77%   69.34%   +0.57%     
- Complexity      793      815      +22     
============================================
  Files           252      254       +2     
  Lines          3654     3752      +98     
  Branches        339      347       +8     
============================================
+ Hits           2513     2602      +89     
+ Misses          949      947       -2     
- Partials        192      203      +11     
Flag Coverage ฮ”
integrationTest 69.05% <79.91%> (+0.61%) โฌ†๏ธ
unitTest 10.02% <21.31%> (+0.22%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah changed the title ๐Ÿ”จ refactor: ํ† ๋„ˆ๋จผํŠธ์— ๊ฒฝ์šฐ isImminent true๋กœ ์ „๋‹ฌ ๐Ÿ”จ [Refactor] ํ† ๋„ˆ๋จผํŠธ์— ๊ฒฝ์šฐ isImminent true๋กœ ์ „๋‹ฌ Dec 21, 2023
@middlefitting middlefitting marked this pull request as draft December 21, 2023 10:33
@middlefitting middlefitting marked this pull request as ready for review December 21, 2023 10:59
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹น

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@middlefitting middlefitting merged commit 65ca710 into dev Dec 21, 2023
2 checks passed
@middlefitting middlefitting deleted the 441-refactoring-ํ† ๋„ˆ๋จผํŠธ-๊ฒŒ์ž„์˜-๊ฒฝ์šฐ-๋ฐ”๋กœ-isimminent-true๋กœ-์„ค์ • branch December 21, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants