Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rework bundling #814

Closed
wants to merge 3 commits into from
Closed

chore: Rework bundling #814

wants to merge 3 commits into from

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Dec 17, 2024 •
edited
Loading

Trying new approaches to solve #708.

Complete unbundling is not the best outcome, as it would expose internals.

Things to try

  • Manually bundling a few files to see if it actually solves the intellisense issue (no need to go further if it doesn't)
  • Find a minimal reproduction by hacking down start-ui and compare with a stock create next-app
  • Rollup could work as a replacement for tsup, we might not want two bundlers (runtime / types)

Another thing to try and solve is how to keep the /** @deprecated */ JSDoc annotations on re-exports.

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 0:59am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 17, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/nuqs@814

commit: fe37585

@franky47 franky47 added the internal Internal issues & discussions label Dec 18, 2024
@franky47 franky47 changed the title chore: Unbundle chore: Rework bundling Dec 19, 2024
@franky47 franky47 closed this Jan 8, 2025
@franky47 franky47 added the 🪦 graveyard Closed PRs (rejected, wontfix, temporary experiments) label Jan 8, 2025
@franky47 franky47 deleted the chore/unbundle branch January 8, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🪦 graveyard Closed PRs (rejected, wontfix, temporary experiments) internal Internal issues & discussions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@franky47