Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: automatic gcc detection #85

Merged
merged 2 commits into from
Nov 3, 2023
Merged

feature: automatic gcc detection #85

merged 2 commits into from
Nov 3, 2023

Conversation

AtomicFS
Copy link
Collaborator

Add mechanism to automatically select GCC to use in compilation.

This is especially useful for EDK2.

@AtomicFS AtomicFS added feature New feature or request github actions labels Oct 31, 2023
@AtomicFS AtomicFS added this to the Refactor the Go action milestone Oct 31, 2023
@AtomicFS AtomicFS force-pushed the feat/add_vbt_and_ec branch 2 times, most recently from 8b26361 to bf6aa3a Compare November 2, 2023 09:21
@AtomicFS AtomicFS force-pushed the feat/automatic_gcc_detection branch from 559be91 to a285f20 Compare November 2, 2023 09:22
Base automatically changed from feat/add_vbt_and_ec to main November 2, 2023 13:06
@AtomicFS
feat(action): add GCC version into edk2 and Linux builds
1a2f835 
- GCC version can be taken from containers environment variable
  GCC_VERSION
- unify input parameters of *GetOpts functions for coreboot,
  Linux and edk2
@AtomicFS
feat(action): add new env var to indicate which GCC version to use
bdbfd72 
- add new environment variable USE_GCC_VERSION into the containers which
  tells the compiler which GCC to use
- this is needed because EDK2 needs option GGC5 even for gcc v9 ...
  don't ask, it is stupid
@AtomicFS AtomicFS force-pushed the feat/automatic_gcc_detection branch from 0e65c02 to bdbfd72 Compare November 2, 2023 13:11
@AtomicFS AtomicFS marked this pull request as ready for review November 2, 2023 13:11
@AtomicFS AtomicFS enabled auto-merge November 2, 2023 13:12
@AtomicFS AtomicFS requested a review from MDr164 November 2, 2023 13:12
MDr164
MDr164 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if having to inputs of the same type where one gets ignored is a big improvement for readability but I see why you opted for it so I'd say lgtm

@AtomicFS AtomicFS added this pull request to the merge queue Nov 3, 2023
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Nov 3, 2023

Yeah, I was not sure if to have it for Linux too, since it is unused at the moment. But maybe we might need it in the future? I don't know.
I was also considering to add it to coreboot to keep things homogeneous, but coreboot has it's own tool-chain, so it is even more useless there.

Merged via the queue into main with commit 74cf26f Nov 3, 2023
25 checks passed
@AtomicFS AtomicFS deleted the feat/automatic_gcc_detection branch November 3, 2023 12:17
@AtomicFS AtomicFS added github_actions Pull requests that update GitHub Actions code and removed github actions labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
feature New feature or request github_actions Pull requests that update GitHub Actions code module/edk2
Projects
None yet
Milestone
Refactor the Go action
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164