WIP: New RPI Coeff Implementation #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test cg and RI functions
cortner
changed the title
|
I extended the test suite to make it comprehensive. At the moment the tests fail when an (nn, ll) doesn't have any invariants at all, e.g., for It seems your new code doesn't like this, but I think this needs to be allowed - one can't expect the user to do this filtering i.e. to know a priori what the zeros in the CG are? |
|
I rewrite the test functions a bit so that the same random batch can be used for all tests so the spans can now be tested more easily. I'll let you clean up the rest of the tests please. |
Give Llset a new and unified implementation. The generation of CG are changed correspondingly.
Test for L = 1:4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #16