Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmafoster1/58 suport snapchat links #685

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jmafoster1
Copy link
Collaborator

@jmafoster1 jmafoster1 commented Dec 9, 2024

Support for scraping snapchat posts with URLs of the forms https://www.snapchat.com/spotlight/<video_id> or https://www.snapchat.com/p/<video_id>. Other URL format suggestions welcome.
Do not merge until https://github.com/GateNLP/we-verify-app-assistant/pull/224 has been merged and deployed.

@jmafoster1 jmafoster1 marked this pull request as ready for review December 16, 2024 14:13
@jmafoster1 jmafoster1 changed the base branch from master to beta-master December 17, 2024 09:17
Copy link
Collaborator

@rosannamilner rosannamilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Sallaa
Copy link
Contributor

Sallaa commented Jan 6, 2025

Hi @jmafoster1 your pr looks good to me. Thanks for adding Snapchat. Could you fix the conflicts? I will merge it after

…ugin into jmafoster1/58-suport-snapchat-links
@jmafoster1
Copy link
Collaborator Author

Done

@Sallaa Sallaa merged commit 5f0412c into beta-master Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants