Skip to content

Commit

Permalink
[main] Fix wordings
Browse files Browse the repository at this point in the history
This patch fixes some wording choices following the review by Sally
Neale.
  • Loading branch information
vhscampos committed Nov 23, 2022
1 parent 6b6b3b1 commit 9188d43
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions main/acle.md
Original file line number Diff line number Diff line change
Expand Up @@ -536,10 +536,10 @@ anchor that can be referred via an internal hyperlink to the paragraph
> double f() { return another_func(1.0, 2, "oranges"); }
> ```
>
> Functions like `some_func` and `another_func` are referred to as
> Functions such as `some_func` and `another_func` are referred to as
> (K&R-style) “unprototyped” functions. The first C standard categorized
> them as an obsolescent feature and C18 removed all remaining support
> for them.
> these functions as an obsolescent feature and C18 removed all remaining
> support for them.

## Conventions

Expand Down Expand Up @@ -2342,7 +2342,7 @@ following:
two.
* If a name is not recognized the compiler should ignore it[^fmv-note-ignore].

[^fmv-note-ignore]: The intention is to support the usecase of newer code is
[^fmv-note-ignore]: The intention is to support the usecase of newer code if
compiled with an older compiler. The compiler may provide diagnostic message
and could block the compilation for example in case of `-fpendantic`.

Expand Down
2 changes: 1 addition & 1 deletion main/design_documents/function-multi-versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ derived from a function via FMV:
2. the derived function obey to the same calling convention of the original
function.

Today the `target` [attribute for aarch64](https://gcc.gnu.org/onlinedocs/gcc/extensions-to-the-c-language-family/declaring-attributes-of-functions/aarch64-function-attributes.html)
Currently the `target` [attribute for aarch64](https://gcc.gnu.org/onlinedocs/gcc/extensions-to-the-c-language-family/declaring-attributes-of-functions/aarch64-function-attributes.html)
is used for many purposes, some of which might overlap the functionality
introduced by FMV. To avoid confusion, we named the attributes used by FMV with
`target_version` and `target_clones`.
Expand Down

0 comments on commit 9188d43

Please sign in to comment.