Skip to content

Commit

Permalink
Add option to hide person cards
Browse files Browse the repository at this point in the history 
Now you should be able to hide person entities from the home page.
  • Loading branch information
@AalianKhan
AalianKhan committed Jun 26, 2023
1 parent e038bc6 commit 5bded12
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 19 deletions.
Loading

3 comments on commit 5bded12

@AalianKhan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DigiLive,
I didn't mean to commit directly, I wanted to create a pull request and ask for your review.
I was using GitHub desktop, downloaded the repository, did my changes and accidentally committed to the main branch. Was I supposed to create a new branch in order to make a pull request into main?

@DigiLive
Copy link
Collaborator

@DigiLive DigiLive commented on 5bded12 Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By agreement, developers should contribute their work by means of a flow.

AFAIK, all flow do say, when working on code, you always create a new working branch which can be merged in the main branch later on.
Since this repository is pretty light and it's just the both of use, we can apply the GitHub flow as described at https://docs.github.com/en/get-started/quickstart/github-flow.

  1. Create a branch
  2. Make changes
  3. Create a pull request
  4. Address review comments
  5. Merge your pull request
  6. Delete your branch

In this case, I don't think committing directly to the main branch has caused any problems.
But I strongly recommend to apply above flow.

For working on issues, there's a link for creating a branch:
afbeelding

@AalianKhan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ❤️

Please sign in to comment.