Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Magic areas + chips #76

Closed
wants to merge 11 commits into from

Conversation

adrienbrault
Copy link
Contributor

Hey,

This includes #75, with the addition of chips for lights, climate, motion and media players.

Here's what it looks like:

This is a start, WDYT?

@DigiLive
Copy link
Collaborator

DigiLive commented Oct 23, 2023

Tanks you for your effort :)

So, if I understand correctly...
This PR replaces #75 which replaces #44?
The other two can be closed?

Could you please add doc-blocks for the added functions/methods, comments to explain the purpose of the pieces of code and also refactor variable/property names into more descriptive ones. E.g. const lock = ... into const lockId = ...

PS: Don't push content of the dist directory. It will create a merge conflict.

@adrienbrault
Copy link
Contributor Author

So, if I understand correctly... This PR replaces #75 which replaces #44? The other two can be closed?

#75 does replace #44.

And this one includes the commits from #75.
But I'd rather get #75 merged first, since #76 isn't quite ready yet IMHO.

Specifically, this MR adds 2 new requirements:

And I wish the AreaCard could automatically create a chip for all lights/media_players/etc, without requiring a group to be configured.

Could you please add doc-blocks for the added functions/methods, comments to explain the purpose of the pieces of code and also refactor variable/property names into more descriptive ones. E.g. const lock = ... into const lockId = ...

PS: Don't push content of the dist directory. It will create a merge conflict.

Noted, I will, on #75 first ;-) !

@DigiLive DigiLive added the enhancement New feature or request label Nov 22, 2023
@DigiLive
Copy link
Collaborator

Warning

The main branch has been switched to TypeScript.
Update your feature branch accordingly!

@adrienbrault
Copy link
Contributor Author

Hey, closing as I won't be working more on this implementation.

I am exploring a different approach: https://github.com/adrienbrault/ha-jsx-strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants