Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up doc comments to be more clear and concise. #123

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

theLee3
Copy link
Collaborator

@theLee3 theLee3 commented Oct 6, 2023

Just a little tweaking of the doc comments to fix typos and make more clear and concise where possible.
Also moved isAuthenticated from BaseGamesServices to Auth for better clarity.

No functionality is changed whatsoever.

Copy link
Owner

@Abedalkareem Abedalkareem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@Abedalkareem
Copy link
Owner

@theLee3 There is a minor conflict here

@theLee3
Copy link
Collaborator Author

theLee3 commented Oct 11, 2023

Ah yes. I submitted for the pre-4.0.0 build. I will rebase onto the current develop branch.

Clean up doc comments to be more clear and concise.
Move `isAuthenticated` from `BaseGamesServices` to `Auth`.
@theLee3 theLee3 force-pushed the clean-up-doc-comments branch from 06341e7 to a0be2ad Compare October 11, 2023 04:57
@theLee3
Copy link
Collaborator Author

theLee3 commented Oct 11, 2023

Updated for version 4.0.0. Should be good now.

@Abedalkareem Abedalkareem merged commit ab07bbd into Abedalkareem:develop Oct 13, 2023
1 check failed
@theLee3 theLee3 deleted the clean-up-doc-comments branch December 1, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants