Check for contains by String rather than creating extra array

Signed-off-by: Sergey Nuyanzin <snuyanzin@gmail.com>
Aiven-Open · Nov 20, 2023 · e131593 · e131593
1 parent cd1218a
commit e131593
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/src/main/java/io/aiven/klaw/service/KafkaConnectControllerService.java b/core/src/main/java/io/aiven/klaw/service/KafkaConnectControllerService.java
@@ -911,8 +911,9 @@ private ApiResponse processRestErrorResponse(HttpStatusCodeException e, String d
   }
 
   private boolean checkInPromotionOrder(String envId, String orderOfEnvs) {
-    List<String> orderedEnv = Arrays.asList(orderOfEnvs.split(","));
-    return orderedEnv.contains(envId);
+    return orderOfEnvs.startsWith(envId + ",")
+        || orderOfEnvs.endsWith("," + envId)
+        || orderOfEnvs.contains("," + envId + ",");
   }
 
   public List<KafkaConnectorRequestsResponseModel> getConnectorRequests(