-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coral): Filters width rendered in TableLayout
is too small
#1927
Comments
TableLayout
should take full widthTableLayout
is too small
@mathieu-anderson can be assigned to me ? |
Yes, I assigned it to you. Thank you! |
@mathieu-anderson Could you please assign this issue to me? I would love to work on this issue as one of my first issues. |
@Reene-Simon , @RANJEETJ06 is already working on it, but if he doesn't open a PR in a reasonable timeframe, I will assign it to you |
@Reene-Simon, @RANJEETJ06 has not opened a PR, and today is the last day of Hacktoberfest. So you may open a PR yourself if you are still up for it ^^ |
@mathieu-anderson sorry but I won't be able to do it today as I'm not familiar with the application and its setup on my local device. I'm a newbie and don't have quite a lot of experience in the same. Honestly, I thought the issue could be fixed with CSS hence I requested to be assigned. But the whole setup looks quite intimidating. I would be open to trying it out in the near future after understanding everything that is being used here and surely contribute to this repo as it does look quite interesting. |
@Reene-Simon no worries, take it at your own pace, and don't hesitate to ask questions. You don't have to open the PR today ^^ |
@mathieu-anderson yeah sure. Thanks for the opportunity. It will truly be a learning experience for me. |
@Reene-Simon I'm sorry, I opened a PR for this as we need it to render a specific UI for a new feature! #1991 |
@mathieu-anderson it's okay. I will surely try to contribute in the future to this repo. |
What happened?
The filer components rendered in
TableLayout
often end up to small in width, which leads to overlapping of content with possible icons in fields (most noticeable in dropdown fields):What did you expect to happen?
The filters should take an appropriate amount of space to avoid such visual issues.
One solution would be to rewrite the flex styles here in this way:
This gives us this result:
Screen.Recording.2023-10-25.at.11.11.30.mov
However, this should be tested, and another solution may be better.
The text was updated successfully, but these errors were encountered: