Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coral): Filters width rendered in TableLayout is too small #1927

Closed
mathieu-anderson opened this issue Oct 25, 2023 · 10 comments · Fixed by #1991
Closed

fix(coral): Filters width rendered in TableLayout is too small #1927

mathieu-anderson opened this issue Oct 25, 2023 · 10 comments · Fixed by #1991
Assignees
Labels
bug Something isn't working Frontend Relates to coral (react app) good first issue Good for newcomers

Comments

@mathieu-anderson
Copy link
Contributor

What happened?

The filer components rendered in TableLayout often end up to small in width, which leads to overlapping of content with possible icons in fields (most noticeable in dropdown fields):

Screenshot 2023-10-25 at 10 11 24

What did you expect to happen?

The filters should take an appropriate amount of space to avoid such visual issues.

One solution would be to rewrite the flex styles here in this way:

     <Box.Flex
        flexDirection={"row"}
        flexWrap={"wrap"}
        alignItems={"center"}
        justifyContent={"space-between"}
        colGap={"l1"}
        marginY={"l1"}
      >
        {filters.map((element) => {
          return (
            <Box.Flex
              key={element.key}
              flexDirection={"column"}
              flex={"1 0 auto"}
            >
              {element}
            </Box.Flex>
          );
        })}
      </Box.Flex>

This gives us this result:

Screen.Recording.2023-10-25.at.11.11.30.mov

However, this should be tested, and another solution may be better.

@mathieu-anderson mathieu-anderson added bug Something isn't working good first issue Good for newcomers Frontend Relates to coral (react app) hacktoberfest labels Oct 25, 2023
@mathieu-anderson mathieu-anderson changed the title fix(coral): Filters rendered in TableLayout should take full width fix(coral): Filters width rendered in TableLayout is too small Oct 25, 2023
@RANJEETJ06
Copy link

@mathieu-anderson can be assigned to me ?

@mathieu-anderson
Copy link
Contributor Author

Yes, I assigned it to you. Thank you!

@Reene-Simon
Copy link

Reene-Simon commented Oct 27, 2023

@mathieu-anderson Could you please assign this issue to me? I would love to work on this issue as one of my first issues.

@mathieu-anderson
Copy link
Contributor Author

@Reene-Simon , @RANJEETJ06 is already working on it, but if he doesn't open a PR in a reasonable timeframe, I will assign it to you

@mathieu-anderson
Copy link
Contributor Author

@Reene-Simon, @RANJEETJ06 has not opened a PR, and today is the last day of Hacktoberfest. So you may open a PR yourself if you are still up for it ^^

@Reene-Simon
Copy link

@mathieu-anderson sorry but I won't be able to do it today as I'm not familiar with the application and its setup on my local device. I'm a newbie and don't have quite a lot of experience in the same. Honestly, I thought the issue could be fixed with CSS hence I requested to be assigned. But the whole setup looks quite intimidating. I would be open to trying it out in the near future after understanding everything that is being used here and surely contribute to this repo as it does look quite interesting.

@mathieu-anderson
Copy link
Contributor Author

@Reene-Simon no worries, take it at your own pace, and don't hesitate to ask questions. You don't have to open the PR today ^^

@Reene-Simon
Copy link

@mathieu-anderson yeah sure. Thanks for the opportunity. It will truly be a learning experience for me.

@mathieu-anderson
Copy link
Contributor Author

@Reene-Simon I'm sorry, I opened a PR for this as we need it to render a specific UI for a new feature! #1991

@Reene-Simon
Copy link

@mathieu-anderson it's okay. I will surely try to contribute in the future to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend Relates to coral (react app) good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants