Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coral) - Fix TableLayout filters row #1991

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix(coral) - Fix TableLayout filters row #1991

merged 2 commits into from
Nov 17, 2023

Conversation

mathieu-anderson
Copy link
Contributor

@mathieu-anderson mathieu-anderson commented Nov 16, 2023

Linked issue

Resolves: #1927

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

The filters rendered in the TableLayout are too small for most content

What is the new behavior?

Better behaviour all around for this row:

Screen.Recording.2023-11-16.at.17.12.17.mov

Other information

I am opening this PR as it is needed to render the UI for #1989

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
@mathieu-anderson mathieu-anderson added enhancement New feature or request Frontend Relates to coral (react app) labels Nov 16, 2023
@mathieu-anderson mathieu-anderson self-assigned this Nov 16, 2023
@mathieu-anderson mathieu-anderson changed the title fix(coral) - Fix TableLayout filters row fix(coral) - Fix TableLayout filters row Nov 16, 2023
@programmiri programmiri merged commit cc30b19 into main Nov 17, 2023
17 of 18 checks passed
@programmiri programmiri deleted the 1927-fix-filters branch November 17, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Frontend Relates to coral (react app)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(coral): Filters width rendered in TableLayout is too small
2 participants