Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coral): View users #1971

Merged
merged 16 commits into from
Nov 20, 2023
Merged

feat(coral): View users #1971

merged 16 commits into from
Nov 20, 2023

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Nov 8, 2023

Linked issue

Resolves: #1176

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

Description

Adds user overview based on layout and existing app, similar to teams overview.

Recording

recording.mov

Description PR changes

  • adds pages and links to it behind a feature flag
  • adds user table with pagination
  • adds user domain with api call and types for getting the user list
  • Extents the existing <TeamFilter /> to optional handle teamName instead of teamId
  • According to that extends userFilterContext
  • adds filter for team name
  • adds search for user name

Unrelated change, but I noticed it:
(this may be related to a DS update since it's not as visible on staging)

  • update the main.module.css to overwrite browser styles for the little X in a search input (was only in webkit browser)

This is how it looked before:

Screenshot 2023-11-08 at 18 29 28

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@programmiri programmiri force-pushed the 1176-view-users branch 4 times, most recently from d19db59 to 270f1dc Compare November 10, 2023 09:47
@programmiri programmiri marked this pull request as ready for review November 10, 2023 09:48
@programmiri programmiri self-assigned this Nov 13, 2023
Copy link
Contributor

@mathieu-anderson mathieu-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks and questions ^^ One TS error though, curious as to how I see it locally but not on CI, or presumably in your editor 🤔
Screenshot 2023-11-17 at 15 54 15

coral/src/app/features/configuration/users/Users.tsx Outdated Show resolved Hide resolved
coral/src/app/features/configuration/users/Users.tsx Outdated Show resolved Hide resolved
coral/src/app/main.module.css Show resolved Hide resolved
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
Signed-off-by: Mirjam Aulbach <mirjam.aulbach@aiven.io>
@mathieu-anderson mathieu-anderson merged commit 88a7235 into main Nov 20, 2023
24 checks passed
@mathieu-anderson mathieu-anderson deleted the 1176-view-users branch November 20, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Users
2 participants