Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to return the days the requests occur on for Requests Per Day #1985

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

aindriu-aiven
Copy link
Contributor

@aindriu-aiven aindriu-aiven commented Nov 16, 2023

Linked issue

Resolves: #xxxxx

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Activitycount instead of the date is returned for the x axis.
image

What is the new behavior?

The date is now returned for the x axis
image

Other information

There is a second unrelated but new issue on the Topics per cluster graph which I will open a separate PR for.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
muralibasani
muralibasani previously approved these changes Nov 16, 2023
Copy link
Contributor

@muralibasani muralibasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
@aindriu-aiven aindriu-aiven merged commit e24ce82 into main Nov 16, 2023
15 checks passed
@aindriu-aiven aindriu-aiven deleted the analytics-timeline-defect branch November 16, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants