add tof paylaod limits #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
reviewed
Oct 8, 2023
| @@ -680,6 +680,7 @@ defaults: | |||
| - tof-full-qcmn-paran-10cmp-local | |||
| - tof-full-qcmn-paran-15cmp-local | |||
| - tof-full-qcmn-cdump-15cmp-local | |||
| - tof-full-qcmn-cdump-bckp-local | |||
There was a problem hiding this comment.
there is no such workflow in the master nor your PR, a leftover from some tests?
There was a problem hiding this comment.
You are right, I forgot to add it when I commit. I'm going to open a new PR since this is already merged
|
does it have the RC blessing to bring it to P2? |
vascobarroso
approved these changes
Oct 8, 2023
vascobarroso
pushed a commit
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add a payload limit in TOF compressor raw-decoding.
A limit of 10M is added to all the default workflows (15cmp) with different settings.
An additional workflow was added
tof-full-qcmn-cdump-bckp-local
as a backup of the previous tof-full-qcmn-cdump-15cmp-local version, in case we need to go back to previous behavior
We need this PR in master and at P2 as soon as possible (before of the today Pb-Pb runs)
We ran some tests this morning to see if the features we implemented work properly. All tests passed.