Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2-5372 Allow ITS to accept CRU packets during PFR/EOR #665

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

knopers8
Copy link
Collaborator

@knopers8 knopers8 commented Oct 2, 2024

No description provided.

@vascobarroso vascobarroso requested a review from teo October 7, 2024 15:23
@vascobarroso
Copy link
Member

@teo this has been tested by @pippohub on STAGING and seems to work as expected.
One thing he mentioned is that when the basic task fails (e.g. he tested without the script being present on the FLP) the env does not go to error even if the task is critical. Maybe because the env is already destroying anyway ? If you want to check the logs, here's a sample env id: 2qFkZfxHTBA

@teo
Copy link
Member

teo commented Oct 8, 2024

@teo this has been tested by @pippohub on STAGING and seems to work as expected. One thing he mentioned is that when the basic task fails (e.g. he tested without the script being present on the FLP) the env does not go to error even if the task is critical. Maybe because the env is already destroying anyway ? If you want to check the logs, here's a sample env id: 2qFkZfxHTBA

Yes, I confirm this behaviour. At DESTROY we only log any hook failure to IL. By the time this hook runs, there is no environment state to speak of because all the tasks have been torn down already, so we don't use the critical flag at all.

Criticality would still apply if this hook task ran at any earlier time in the environment state machine.

@vascobarroso vascobarroso merged commit b7fae80 into AliceO2Group:master Oct 8, 2024
1 check passed
@knopers8 knopers8 deleted the o2-5372 branch October 9, 2024 09:15
@knopers8 knopers8 restored the o2-5372 branch October 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants