Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOF: Add moving window in TOF asynch jsons #1759

Merged
merged 1 commit into from
Oct 8, 2024
Merged

TOF: Add moving window in TOF asynch jsons #1759

merged 1 commit into from
Oct 8, 2024

Conversation

ercolessi
Copy link
Contributor

This PR is to add moving window for asynch TOF objects:

DecodingErrors
HitMap
OrbitVsCrate
mEffPt_ITSTPC-ITSTPCTRD
EvTimeTOF
DeltaEvTimeTOFVsFT0AC

Cc @noferini

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@njacazio njacazio enabled auto-merge (squash) October 2, 2024 16:00
@chiarazampolli
Copy link
Collaborator

@JianLIUhep , can you review? Thanks!

@JianLIUhep
Copy link
Contributor

Yes, the code is good for me.
I also understood from @ercolessi that the local test was successful. The memory size looks reasonable as Francesca updated in the table.
So, it's ok to merge on my side. @chiarazampolli

@ercolessi
Copy link
Contributor Author

ercolessi commented Oct 8, 2024 •
edited
Loading

I confirm it was tested locally! Thanks @JianLIUhep

@njacazio njacazio merged commit 8a53dfe into AliceO2Group:master Oct 8, 2024
7 checks passed
alcaliva pushed a commit that referenced this pull request Nov 3, 2024
@ercolessi @alcaliva
Add moving window for TOF objects (#1759)
48da734 
minor

(cherry picked from commit 8a53dfe)
alcaliva pushed a commit that referenced this pull request Nov 7, 2024
@ercolessi @alcaliva
Add moving window for TOF objects (#1759)
3da5e65 
minor

(cherry picked from commit 8a53dfe)
@chiarazampolli
Copy link
Collaborator

In async-v1-01-12d for cpass0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiarazampolli chiarazampolli chiarazampolli approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@martenole martenole Awaiting requested review from martenole

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees
No one assigned
Labels
async-2024-PbPb-apass1 async-2024-ppRef-apass1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ercolessi @chiarazampolli @JianLIUhep @njacazio @noferini @alcaliva