Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC] Scripts needed to run upcgen as external generator #1811

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

pbuehler
Copy link
Contributor

Adding scripts which are required to use the event generator upcgen in O2 simulations.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@pbuehler pbuehler changed the title Scripts needed to run upcgen as external generator [MC] Scripts needed to run upcgen as external generator Nov 21, 2024
Comment on lines +15 to +17
void setLumiFileDirectory(std::string lumiFileDirectory) {
mUPCgen->setLumiFileDirectory(lumiFileDirectory);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pbuehler,

Upcgen does not have this function. Do you have some local changes that you will commit later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed and the method setLumiFileDirectory was implemented in Upcgen.

@pbuehler
Copy link
Contributor Author

Dear @sawenzel, @benedikt-voelkel, @chiarazampolli, can I ask you to approve this PR please? It is needed to run the upcgen generator in O2 simulations. We want to use this in simulations for the UD group.

@sawenzel sawenzel merged commit 2da42d9 into AliceO2Group:master Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants