Skip to content

Commit

Permalink
Minors
Browse files Browse the repository at this point in the history
  • Loading branch information
gvolpe79 committed Nov 15, 2023
1 parent 634b063 commit 458d7d1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 29 deletions.
6 changes: 1 addition & 5 deletions Modules/HMPID/include/HMPID/HmpidTaskMatches.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,8 @@
#include "ReconstructionDataFormats/MatchInfoHMP.h"
#include "SimulationDataFormat/MCCompLabel.h"

#include <TH1.h>
#include <TProfile.h>
#include <TH2.h>

class TH1F;
class TH2F;

using namespace o2::quality_control::core;
using GID = o2::dataformats::GlobalTrackID;
Expand All @@ -53,7 +50,6 @@ class HmpidTaskMatches : public TaskInterface

private:
void BookHistograms();
void getJsonParameters();

std::shared_ptr<o2::globaltracking::DataRequest> mDataRequest;
o2::globaltracking::RecoContainer mRecoCont;
Expand Down
23 changes: 0 additions & 23 deletions Modules/HMPID/src/HmpidTaskMatches.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,13 @@
#include "DataFormatsHMP/Cluster.h"
#include "ReconstructionDataFormats/MatchInfoHMP.h"

#ifdef WITH_OPENMP
#include <omp.h>
#endif

namespace o2::quality_control_modules::hmpid
{

HmpidTaskMatches::HmpidTaskMatches() : TaskInterface() {}

HmpidTaskMatches::~HmpidTaskMatches()
{
ILOG(Info, Support) << "destructor called" << ENDM;
for (int iCh = 0; iCh < 7; iCh++) {
delete mMatchInfoResidualsXTrackMIP[iCh];
delete mMatchInfoResidualsYTrackMIP[iCh];
Expand All @@ -57,16 +52,11 @@ HmpidTaskMatches::~HmpidTaskMatches()

void HmpidTaskMatches::initialize(o2::framework::InitContext& /*ctx*/)
{
ILOG(Debug, Devel) << "initialize TaskMatches" << ENDM;

mDataRequest = std::make_shared<o2::globaltracking::DataRequest>();
mDataRequest->requestTracks(mSrc, false);

// getJsonParameters();

BookHistograms();

// publish histograms (Q: why publishing in initalize?)
for (int iCh = 0; iCh < 7; iCh++) {

getObjectsManager()->startPublishing(mMatchInfoResidualsXTrackMIP[iCh]);
Expand All @@ -78,10 +68,6 @@ void HmpidTaskMatches::initialize(o2::framework::InitContext& /*ctx*/)
getObjectsManager()->setDisplayHint(mMatchInfoClusterMIPMap[iCh], "colz");
getObjectsManager()->startPublishing(mMatchInfoThetaCherenkovVsMom[iCh]);
}

ILOG(Info, Support) << "START DOING QC HMPID Matches" << ENDM;

// here do the QC
}

void HmpidTaskMatches::startOfActivity(const Activity& /*activity*/)
Expand All @@ -97,8 +83,6 @@ void HmpidTaskMatches::startOfCycle()

void HmpidTaskMatches::monitorData(o2::framework::ProcessingContext& ctx)
{
ILOG(Info, Support) << "monitorData" << ENDM;

mRecoCont.collectData(ctx, *mDataRequest.get());

// HMP
Expand Down Expand Up @@ -137,7 +121,6 @@ void HmpidTaskMatches::monitorData(o2::framework::ProcessingContext& ctx)

void HmpidTaskMatches::endOfCycle()
{

ILOG(Debug, Devel) << "endOfCycle" << ENDM;
}

Expand Down Expand Up @@ -176,10 +159,4 @@ void HmpidTaskMatches::reset()
mMatchInfoThetaCherenkovVsMom[iCh]->Reset();
}
}

void HmpidTaskMatches::getJsonParameters()
{
ILOG(Info, Support) << "GetJsonParams" << ENDM;
}

} // namespace o2::quality_control_modules::hmpid
2 changes: 1 addition & 1 deletion Modules/HMPID/src/clusters.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"tasks":{
"TaskClusters":{
"active":"true",
"className":"o2::quality_control_modules::hmpid::HmpidTaskPippo",
"className":"o2::quality_control_modules::hmpid::HmpidTaskClusters",
"moduleName":"QcHMPID",
"detectorName":"HMP",
"cycleDurationSeconds":"10",
Expand Down

0 comments on commit 458d7d1

Please sign in to comment.