Skip to content

Commit

Permalink
removed numberInputs
Browse files Browse the repository at this point in the history
  • Loading branch information
Michal Tichák committed Aug 9, 2024
1 parent 4b1a3e7 commit afce9be
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
3 changes: 1 addition & 2 deletions Modules/Daq/include/Daq/DaqTask.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class DaqTask final : public o2::quality_control::core::TaskInterface
{
public:
/// \brief Constructor
DaqTask();
DaqTask() = default;

// Definition of the methods for the template method pattern
void initialize(o2::framework::InitContext& ctx) override;
Expand All @@ -67,7 +67,6 @@ class DaqTask final : public o2::quality_control::core::TaskInterface
// Block = the whole InputRecord, i.e. the thing we receive and analyse in monitorData(...)
// SubBlock = a single input of the InputRecord
std::unique_ptr<TH1F> mInputRecordPayloadSize; // filled w/ the sum of the payload size of all the inputs of an inputrecord
std::unique_ptr<TH1F> mNumberInputs; // filled w/ the number of inputs in each InputRecord we encounter
std::unique_ptr<TH1F> mInputSize; // filled w/ the size of the inputs in each InputRecord we encounter
std::unique_ptr<TH1F> mNumberRDHs; // filled w/ the number of RDHs found in each InputRecord we encounter

Expand Down
9 changes: 0 additions & 9 deletions Modules/Daq/src/DaqTask.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ using namespace o2::header;
namespace o2::quality_control_modules::daq
{

DaqTask::DaqTask()
: TaskInterface()
{
}

// TODO remove this function once the equivalent is available in O2 DAQID
bool isDetIdValid(DAQID::ID id)
{
Expand All @@ -53,8 +48,6 @@ void DaqTask::initialize(o2::framework::InitContext& /*ctx*/)
mInputRecordPayloadSize = std::make_unique<TH1F>("inputRecordSize", "Total payload size per InputRecord;bytes", 128, 0, 2047);
mInputRecordPayloadSize->SetCanExtend(TH1::kXaxis);
getObjectsManager()->startPublishing(mInputRecordPayloadSize.get(), PublicationPolicy::Forever);
mNumberInputs = std::make_unique<TH1F>("numberInputs", "Number of inputs per InputRecords", 100, 1, 100);
getObjectsManager()->startPublishing(mNumberInputs.get(), PublicationPolicy::Forever);
mInputSize = std::make_unique<TH1F>("payloadSizeInputs", "Payload size of the inputs;bytes", 128, 0, 2047);
mInputSize->SetCanExtend(TH1::kXaxis);
getObjectsManager()->startPublishing(mInputSize.get(), PublicationPolicy::Forever);
Expand Down Expand Up @@ -140,7 +133,6 @@ void DaqTask::reset()
// then we can just iterate over.

mInputRecordPayloadSize->Reset();
mNumberInputs->Reset();
mInputSize->Reset();
mNumberRDHs->Reset();

Expand Down Expand Up @@ -209,7 +201,6 @@ void DaqTask::monitorInputRecord(InputRecord& inputRecord)
}
}
mInputRecordPayloadSize->Fill(totalPayloadSize);
mNumberInputs->Fill(inputRecord.countValidInputs());
}

template <class T>
Expand Down

0 comments on commit afce9be

Please sign in to comment.