remove duplicate inputs

AliceO2Group · Nov 10, 2023 · cc8fd06 · cc8fd06
1 parent e677f93
commit cc8fd06
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/Framework/src/CheckRunnerFactory.cxx b/Framework/src/CheckRunnerFactory.cxx
@@ -42,7 +42,17 @@ DataProcessorSpec CheckRunnerFactory::create(CheckRunnerConfig checkRunnerConfig
     allInputs.insert(allInputs.end(), config.inputSpecs.begin(), config.inputSpecs.end());
   }
 
-  CheckRunner qcCheckRunner{ std::move(checkRunnerConfig), checkConfigs, allInputs };
+  // We can end up with duplicated inputs that will later lead to circular dependencies on the checkRunner device.
+  o2::framework::Inputs allInputsNoDups;
+  std::set<std::string> alreadySeen;
+  for(auto input: allInputs) {
+    if(alreadySeen.count(input.binding) == 0) {
+      allInputsNoDups.push_back(input);
+    }
+    alreadySeen.insert(input.binding);
+  }
+
+  CheckRunner qcCheckRunner{ std::move(checkRunnerConfig), checkConfigs, allInputsNoDups };
 
   DataProcessorSpec newCheckRunner{ qcCheckRunner.getDeviceName(),
                                     qcCheckRunner.getInputs(),

diff --git a/Framework/test/testInfrastructureGenerator.cxx b/Framework/test/testInfrastructureGenerator.cxx
@@ -187,7 +187,7 @@ TEST_CASE("qc_factory_remote_test")
     workflow.begin(), workflow.end(),
     [](const DataProcessorSpec& d) {
       return d.name.find("qc-check") != std::string::npos &&
-             d.inputs.size() == 7;
+             d.inputs.size() == 4;
     });
   REQUIRE(checkRunnerCount == 1);
 
@@ -260,7 +260,7 @@ TEST_CASE("qc_factory_standalone_test")
     workflow.begin(), workflow.end(),
     [](const DataProcessorSpec& d) {
       return d.name.find("qc-check") != std::string::npos &&
-             d.inputs.size() == 7;
+             d.inputs.size() == 4;
     });
   REQUIRE(checkRunnerCount == 1);
 
@@ -367,7 +367,7 @@ TEST_CASE("qc_infrastructure_local_batch_test")
     CHECK(workflow[4].outputs.size() == 0);
   }
 }
-
+using namespace  std;
 TEST_CASE("qc_infrastructure_remote_batch_test")
 {
   std::string configFilePath = std::string("json://") + getTestDataDirectory() + "testSharedConfig.json";
@@ -390,7 +390,7 @@ TEST_CASE("qc_infrastructure_remote_batch_test")
     workflow.begin(), workflow.end(),
     [](const DataProcessorSpec& d) {
       return d.name.find("qc-check") != std::string::npos &&
-             d.inputs.size() == 7;
+             d.inputs.size() == 4;
     });
   REQUIRE(checkRunnerCount == 1);