[WIP] TRD fix ccdb object time requesting [O2-3592] #1674
Conversation
Modules/TRD/TRDQC.json
Outdated
| @@ -58,13 +58,10 @@ | |||
| "cycleDurationSeconds": "60", | |||
| "maxNumberCycles": "-1", | |||
| "dataSource": { | |||
| "type": "direct", | |||
| "query": "digits:TRD/DIGITS;tracklets:TRD/TRACKLETS;triggers:TRD/TRKTRGRD" | |||
| "type": "direct", | |||
There was a problem hiding this comment.
aren't the json files sensitive about spaces at end of lines?
There was a problem hiding this comment.
not sure, it worked when I went over 2 runs from catalog, 522392 and 529462. Still need to verify mc, and change dpg. dpg change will have to wait till new qc.
Modules/TRD/src/TrackletsTask.cxx
Outdated
| return; | ||
| } | ||
| } | ||
| std::cout << "done if statement for noisemap from ccdb" << std::endl; |
There was a problem hiding this comment.
leftover debug statement?
|
CI errors look genuine, please check |
|
There are conflicts could you check ? |
Barthelemy
changed the title
|
Hi, @bazinski what do you want to do with this PR ? fix it or close it ? |
|
Hi @Barthelemy on holiday till 12th will fix when back. Sean |
|
Hi, |
bazinski
force-pushed
the
fixtimestamps
branch
from
5432aab to
34c5fc7
Compare
bazinski
force-pushed
the
fixtimestamps
branch
from
34c5fc7 to
7a5ed3f
Compare
|
@Barthelemy busy checking if its still needed. |
|
@bazinski why did you close this? Shouldn't we anyhow move to the DPL CCDB fetcher in all TRD tasks? |
|
@martenole Indeed, it needs to be expanded, but was not working(tested last week), and the pr was touching files it never should have. I was just going to redo it all, hence closing this. Will get to it next week as per the message on mattermost. |
Fix O2-3592.
Redo the way timestamps are set for ccdb objects.
Objects now defined in the json file as a query input.