TRD: Check on Trigger and timeframe without tracklets #2011
Conversation
|
Hi @martenole , May you review this PR? |
|
Hi @deependra170598 thanks. The code is pretty much the same in |
|
Hi @martenole , May you review new check: Modules/TRD/src/TrackletCountCheck.cxx ? If it looks fine I will remove older checks on Tracklet per trigger and timeframe. |
deependra170598
force-pushed
the
Trigger-Without-Tracklets
branch
from
2cf0b90 to
5ecd5dd
Compare
| continue; | ||
| } | ||
| // warning about statistics available | ||
| msg1 = std::make_shared<TPaveText>(0.3, 0.7, 0.7, 0.9, "NDC"); |
There was a problem hiding this comment.
| msg1 = std::make_shared<TPaveText>(0.3, 0.7, 0.7, 0.9, "NDC"); | |
| if (!msg1) { | |
| msg1 = std::make_shared<TPaveText>(0.3, 0.7, 0.7, 0.9, "NDC"); | |
| msg1->SetTextSize(10); | |
| } |
There was a problem hiding this comment.
In this way, it is inserting each time a new line into the Message pad. To use your suggestion I have to use msg1.reset() before allocating memory so that the text box does not overflow. Am I correct now?
There was a problem hiding this comment.
Hi @martenole , May you review it again?
|
Hi @deependra170598 I don't understand why you need to recreate a new TPaveText everytime. Couldn't you just call clear() on the text box and then add new text in case needed? Anyways, if you have tested it with your current implementation and it worked this is also fine with me. The CI failures don't seem to be related to your changes. |
|
After discussing with @deependra170598 it would be fine for me to merge it as is, if @Barthelemy and @knopers8 agree. Further improvements can be added later. In local tests done by Dependra the checks work as expected. |
|
I agree, merged ! |
In this PR, BinContent of trackletsperevent and trackletspertimeframe at zeroth bin is observed and a warning as a text over the histogram is issue if there is any entry in the zeroth bin.
Also a check is applied on mean of trackletspertimeframe.