Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QC-1020] Fall back to default values if beamtype or runtype cannot b… #2033

Merged

Conversation

Barthelemy
Copy link
Collaborator

…e found.

@Barthelemy Barthelemy requested a review from knopers8 as a code owner November 14, 2023 14:37
@Barthelemy
Copy link
Collaborator Author

@aferrero2707 This is what you asked for the CustomParameters: if a value is not defined for the requested beam/run type, we use the one defined for "default" (if any).

To me it seems a bit confusing but I see the benefit as well.

Framework/src/CustomParameters.cxx Outdated Show resolved Hide resolved
@aferrero2707
Copy link
Contributor

@Barthelemy is there a specific reason why there is no implementation of this version of at()?

std::string CustomParameters::at(const std::string& key, const Activity& activity)

@Barthelemy
Copy link
Collaborator Author

  1. I added the missing version of at
  2. loop: yes
  3. doc: yes

Thanks !

@Barthelemy Barthelemy enabled auto-merge (squash) November 21, 2023 10:16
@Barthelemy Barthelemy merged commit 46aa0b9 into AliceO2Group:master Nov 21, 2023
2 checks passed
@Barthelemy Barthelemy deleted the CustomParameters-fallback-default branch November 21, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants