Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRD digit QC protection against division by zero #2049

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

martenole
Copy link
Contributor

Fix for FPE observed in alibi nightly MC tests.
Ping @knopers8

@knopers8 knopers8 enabled auto-merge (squash) November 28, 2023 14:58
@knopers8 knopers8 merged commit 72358b2 into AliceO2Group:master Nov 28, 2023
7 checks passed
@chiarazampolli
Copy link
Contributor

Hello @martenole , @knopers8 ,

We will need a new tag from QC for PbPb with this fix. Can this be done? We would need it as soon as possible - as always :-)

Cheers,
Chiara

@knopers8
Copy link
Collaborator

Hi @chiarazampolli yes of course. Can you remind me which major release is this?

@chiarazampolli
Copy link
Contributor

Actually, at the moment we are using v1.123.0, so the bug is not there. But in general, we should understand how to handle data and MC when we use dev/master of O2/O2DPG, but an "old" tag from QC...

@martenole
Copy link
Contributor Author

Hi @chiarazampolli the bug has been there for a very long time. Also in v1.123.0 it is present. It is just very unlikely to have zero tracklets for a whole TF that's why it appeared only once now. I doubt it will ever happen in PbPb, but still I think it would be better to have the protection in..

@chiarazampolli
Copy link
Contributor

Hello @martenole ,
Was it not introduced here?
martenole@6a6b601
Screenshot 2023-11-29 at 11 06 21
Maybe I am overlooking...
Chiara

@knopers8
Copy link
Collaborator

I doubt it will ever happen in PbPb, but still I think it would be better to have the protection in..

In alibi it happened a few nights in a row over the weekend, so it's likely that the bug was introduced recently.

@martenole
Copy link
Contributor Author

Hello @martenole , Was it not introduced here?

Yes, you are right, sorry. Indeed I introduced the bug in #2037 and checked wrongly for an older version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants