Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QC-885] Modify reference check to also accept a TH1 … #2358

Merged
merged 26 commits into from
Jul 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1a6b31d
[QC-885] Modify ReferenceComparatorCheck to also accept a TH1 instead…
Barthelemy Jun 26, 2024
603a00c
format
Barthelemy Jun 26, 2024
626e7c4
add beautify and doc
Barthelemy Jun 26, 2024
d23cfcd
Format
Barthelemy Jun 26, 2024
714a486
Format
Barthelemy Jun 26, 2024
466a984
cout
Barthelemy Jun 26, 2024
a1ad044
Update ReferenceComparatorCheck.cxx
Barthelemy Jun 26, 2024
4755f09
Update Advanced.md
Barthelemy Jun 26, 2024
d6cb6e1
Update Advanced.md
Barthelemy Jun 26, 2024
6f9e9ef
Update DevelopersTips.md
Barthelemy Jun 26, 2024
4b1c4d4
Merge branch 'master' into ref-plot-check
Barthelemy Jul 1, 2024
142565f
Update Framework/include/QualityControl/ReferenceUtils.h
Barthelemy Jul 1, 2024
71e7460
Update Modules/Common/src/ReferenceComparatorCheck.cxx
Barthelemy Jul 1, 2024
591aa86
Update doc/Advanced.md
Barthelemy Jul 1, 2024
5523798
Update doc/Advanced.md
Barthelemy Jul 1, 2024
81a00d1
Update ReferenceComparatorCheck.cxx
Barthelemy Jul 1, 2024
5262cce
Update ReferenceComparatorCheck.cxx
Barthelemy Jul 1, 2024
ee37571
- use int for the run
Barthelemy Jul 1, 2024
3c62749
format
Barthelemy Jul 1, 2024
da08db6
return a tuple
Barthelemy Jul 1, 2024
1ffb5ed
format
Barthelemy Jul 2, 2024
f84803a
return null quality if no reference run number is provided.
Barthelemy Jul 3, 2024
3da5995
extraction
Barthelemy Jul 3, 2024
da17738
- Keep the activity parameter but document it
Barthelemy Jul 5, 2024
371a1a6
Use extended parameters.
Barthelemy Jul 5, 2024
fd93cdf
pass only 1 activity for reference and not the reference run + the cu…
Barthelemy Jul 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Modules/Common/src/ReferenceComparatorCheck.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@ Quality ReferenceComparatorCheck::getSinglePlotQuality(std::shared_ptr<MonitorOb
message = "The MonitorObject is not a TH1";
return Quality::Null;
}
auto referenceRun = std::stoi(mCustomParameters.atOptional("referenceRun").value_or("0"));
if (mCustomParameters.count("referenceRun") == 0) {
message = "No reference run provided";
return Quality::Null;
}
auto referenceRun = std::stoi(mCustomParameters.at("referenceRun"));
Barthelemy marked this conversation as resolved.
Show resolved Hide resolved

// get path of mo and ref (we have to remove the provenance)
string path = mo->getPath();
Expand All @@ -154,7 +158,7 @@ Quality ReferenceComparatorCheck::getSinglePlotQuality(std::shared_ptr<MonitorOb

auto referencePlot = retrieveReference(path, referenceRun, mActivity);
if (!referencePlot) {
message = "The reference plot is empty";
message = "Reference plot not found";
return Quality::Null;
}
auto* ref = dynamic_cast<TH1*>(referencePlot->getObject());
Expand Down
Loading