[QC-1026] Separate source / target QCDB for postprocessing #2371
Conversation
Barthelemy
changed the title
Barthelemy
changed the title
| if (mPublicationCallback == nullptr) { | ||
| mPublicationCallback = publishToRepository(*mDatabase); | ||
| mPublicationCallback = publishToRepository(*mDestinationDatabase); |
There was a problem hiding this comment.
If done like this, it will only work in cases when a postprocessing task is ran with o2-qc-run-postprocessing, that is without DPL. When we run with DPL, this callback is set by PostProcessingDevice to publish objects into DPL, then CheckRunners receive them, apply Checks and store them to the database they use.
I think it will be very misleading if it works only for some cases.
How about getting rid of the destinationRepo parameter and using always the main repo as the destination?
There was a problem hiding this comment.
yes, we can do that for the destinatino repo. I did not think of this issue and thought that why not add both source and destination. I'll amend the PR.
There was a problem hiding this comment.
I have pushed a commit
I kept "destinationDatabase" in the `PostProcessingRunnerConfig` because there is a "sourceDatabase" and having "mDatabase" seemed confusing.
No description provided.