CcdbInspector: run number specified in CCDB queries #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
In the case of queries to the CCDB the metadata was completely empty, so the latest version of the queried object was retrieved regardless of the run number. This leads to failures in retrieving the appropriate object in cases where the same type of object is updated by multiple parallel runs, as it is the case for example for the CTP configuration object. In such cases the object from the wrong run might be retrieved, if it was created shortly after the good one. To avoid that this kind of corner cases leads to wrongly reported failures, the run number is now explicitly set in the metadata used for the CCDB queries, as it was already done for the QCDB ones.
aferrero2707
force-pushed
the
common-specify-run-number-in-ccdbinspector-queries
branch
from
f295f72 to
2931444
Compare
|
@Barthelemy @knopers8 @justonedev1 would it be possible to have this PR reviewed and eventually merged in time for the next release? Thanks a lot! |
Barthelemy
approved these changes
Aug 15, 2024
aferrero2707
deleted the
common-specify-run-number-in-ccdbinspector-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of queries to the CCDB the metadata was completely empty, so the latest version of the queried object was retrieved regardless of the run number.
This leads to failures in retrieving the appropriate object in cases where the same type of object is updated by multiple parallel runs, as it is the case for example for the CTP configuration object. In such cases the object from the wrong run might be retrieved, if it was created shortly after the good one.
To avoid that this kind of corner cases leads to wrongly reported failures, the run number is now explicitly set in the metadata used for the CCDB queries, as it was already done for the QCDB ones.