Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceComparator: allow ignoring period and pass when retrieving reference plots #2381

Conversation

aferrero2707
Copy link
Contributor

The period and pass names were always included in the QCDB queries for retrieving the reference plots. This means that a run from a given period and pass could not be used as reference for a different period and/or pass, which is a strong limitation that needs to be made configurable.

The new code adds two configuration parameters that control whether the period and/or pass names should be ignored or not in the queries (see documentation for details).

The period and pass names were always included in the QCDB queries for
retrieving the reference plots. This means that a run from a given
period and pass could not be used as reference for a different period
and/or pass, which is a strong limitation that needs to be made configurable.

The new code adds two configuration parameters that control whether the
period and/or pass names should be ignored or not in the queries (see
documentation for details).
@aferrero2707
Copy link
Contributor Author

@Barthelemy @knopers8 @justonedev1 would it be possible to have this PR reviewed and eventually merged in time for the next release? Thanks a lot!

Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

It makes sense. I have only a small comment that I let you assess.

Cheers

@Barthelemy Barthelemy merged commit 058c915 into AliceO2Group:master Aug 16, 2024
7 checks passed
@aferrero2707 aferrero2707 deleted the common-ignore-period-and-pass-for-reference-plots branch August 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants