[QC-1112] Develop a task to monitor the TF/payload size #2388
Conversation
justonedev1
changed the title
Barthelemy
changed the title
Modules/Daq/src/DaqTask.cxx
Outdated
| getIntParam("RdhPayloadSizeBins", 128), | ||
| getIntParam("RdhPayloadSizeMin", 0), | ||
| getIntParam("RdhPayloadSizeMax", 2047), | ||
| getIntParam("CRUidBins", 500), |
There was a problem hiding this comment.
Do you know what are CRU IDs normally? I mean, are they incremental IDs or some scattered numbers? If it's the second, we might need to find a better way to put them on an axis rather than just grouping them in bins.
There was a problem hiding this comment.
No, I don't know... I thought that you will tell me if there is going to be a problem. I did not even expect that there is going to be something weird, because in ticket is written just this:
New plots to add
Distribution of the RDH payload sizes vs. CRU IDs (2D histo). Configurable X axis.
There was a problem hiding this comment.
Yes, I had this thought just now. We can check with Pippo then.
There was a problem hiding this comment.
Pippo basically confirmed that it is 12 bits set by users, so it can be anything, as every detector team does their own thing.
There was a problem hiding this comment.
oh well. let's then leave it like this, but set the default max cru ID to 2^12-1. If we need something better, we will get a request.
Modules/Daq/src/DaqTask.cxx
Outdated
| getIntParam("numberRDHsMax", 100)); | ||
| getObjectsManager()->startPublishing(mNumberRDHs.get(), PublicationPolicy::Forever); | ||
|
|
||
| mSumRDHSizesPerInputRecord = std::make_unique<TH1F>("sumRdhSizesPerInputRecord", "Sum of RDH sizes per InputRecord;bytes", |
There was a problem hiding this comment.
It was not in the requirements in the ticket, but looking at the plots, it would be good to change the title to "Sum of RDH sizes in TF". Specifically:
- A lot of people looking at this plot will not know what InputRecord is, so "TF" (for TimeFrame) should be clearer
- Using "in TF" instead of "per TF" might make it clearer that the plot is 1D and would not be understood as "Sums of RDH sizes are on Y axis, TF IDs are on X axis".
Accordingly, the plot name and parameters could be changed, as well as uses of InputRecord in other plots.
@aferrero2707 would you agree?
There was a problem hiding this comment.
@knopers8 @justonedev1 yes, I agree, and sorry for the late feedback!
Modules/Daq/src/DaqTask.cxx
Outdated
| getIntParam("RdhPayloadSizeBins", 128), | ||
| getIntParam("RdhPayloadSizeMin", 0), | ||
| getIntParam("RdhPayloadSizeMax", 2047), |
There was a problem hiding this comment.
These (RdhPayloadSize) are the parameters for X axis, while CRU IDs are Y. Can you flip the axes, so the contents correspond to the title ("RDH payload size per CRU", not "CRU IDs per RDH payload size")?
|
Also, please update QC config example at |
justonedev1
changed the title
I changed daq task regarding to the ticket. I think that everything requested from ticket is there, but obviously there might be better ways how to do things, so I am opening draft to check first.