Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser notification when the agent has finished #6236

Open
neubig opened this issue Jan 13, 2025 · 2 comments · May be fixed by #6246
Open

Browser notification when the agent has finished #6236

neubig opened this issue Jan 13, 2025 · 2 comments · May be fixed by #6246
Labels

Comments

@neubig
Copy link
Contributor

neubig commented Jan 13, 2025

What problem or use case are you trying to solve?

When the agent has been put to work, it's common to tab away to another tab, but you might not notice that the agent has finished.

Describe the UX of the solution you'd like

It would be good if the browser provided a notification when the agent has finished.

Do you have thoughts on the technical implementation?

This should:

  1. Use a standard method for implementing browser notifications.
  2. Be able to be turned on or off in the settings in the UI.

Notes

Thanks @morganmcg1 for the suggestion!

@neubig neubig added enhancement New feature or request fix-me-experimental labels Jan 13, 2025
@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@openhands-agent
Copy link
Contributor

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-6236' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

Additional details about the failure:
The changes made to the test setup file (/frontend/tests/setup.ts) alone cannot resolve this issue. The core requirements were to:

  1. Implement browser notifications when an agent completes its work
  2. Add a UI setting to toggle these notifications

The modification of a test setup file would not implement the actual notification functionality. To properly resolve this issue, we would need to see:

  1. Implementation of the browser Notifications API in the main application code
  2. Logic to trigger notifications when agent tasks complete
  3. Addition of a user setting/toggle in the UI
  4. Any necessary permission handling for browser notifications

Without seeing changes to the actual application code that implements these features, the issue cannot be considered resolved. The test setup file modification alone does not provide the required functionality for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants