New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser notifications tests #6246

Open

neubig wants to merge 3 commits into main from fix-browser-notifications

Contributor

neubig commented Jan 13, 2025 •

edited by github-actions bot

Loading

This PR fixes the browser notifications tests by:

Adding proper mocking of the Notification API in tests
Adding test coverage for the notification service

Fixes #6236

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:dc53583-nikolaik   --name openhands-app-dc53583   docker.all-hands.dev/all-hands-ai/openhands:dc53583

openhands-agent added 3 commits

January 13, 2025 19:17


          Fix browser notifications tests

e0901ee


          Fix frontend lint errors

d3fac27


          Fix frontend test types

dc53583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet