-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add trajectory replay for headless mode #6215
base: main
Are you sure you want to change the base?
Conversation
@@ -108,6 +109,7 @@ def __init__( | |||
is_delegate: Whether this controller is a delegate. | |||
headless_mode: Whether the agent is run in headless mode. | |||
status_callback: Optional callback function to handle status updates. | |||
replay_logs: A list of logs to replay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we call it replay_events, since it is really a list of events
self.replay_logs = replay_logs | ||
self.replay_index = 0 | ||
if self.replay_logs: | ||
logger.info(f'Replay logs loaded, events length = {len(self.replay_logs)}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consolidate these replay related thing to a separate class? eg something like StuckDetector
to help reduce the complexity of AgentController?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, and it's a very self-contained feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, it does execute the actions, right?
End-user friendly description of the problem this fixes or functionality that this introduces
Add trajectory replay feature for headless mode.
Give a summary of what the PR does, explaining any non-trivial design decisions
To test it out, add
replay_trajectory_path
toconfig.toml
, and thenTODOs in this PR:
trajectories_path
config tosave_trajectory_path
#6216 is mergedadd tests(non-trivial, will skip in this PR)TODOs in next PR:
Link of any specific issues this addresses
#6049
To run this PR locally, use the following command: