Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: User id should be a str (Because it will probably be a UUID) #6251

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Jan 13, 2025

User id should be a str (Because the value returned by many IDPs will probably be a UUID)

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Changing the type hints here: int -> str


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2545ede-nikolaik   --name openhands-app-2545ede   docker.all-hands.dev/all-hands-ai/openhands:2545ede

@tofarr tofarr marked this pull request as ready for review January 14, 2025 19:18
@tofarr tofarr merged commit e21cbf6 into main Jan 14, 2025
14 checks passed
@tofarr tofarr deleted the feat-user-id-str branch January 14, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants