Fix issue #6262: [Bug]: "Success/failure" behavior is not consistent for file reading and editing #6263
+113
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #6262.
The changes made directly address the core issue and implement the requested functionality:
The code now properly handles file read/edit operations by modifying the
addAssistantAction
andaddAssistantObservation
functions to show appropriate success/failure indicators for these operations, matching the behavior seen with Python and Bash commands.Success detection was implemented by checking for content presence and absence of error messages in the operation results, providing clear visual feedback through indicators.
The
ExpandableMessage
component was updated to show success/failure indicators consistently, even when there's no headline, ensuring uniform behavior across all action types.These changes should result in:
The modifications directly implement the expected behavior outlined in the issue description, transforming the inconsistent feedback into a standardized system for all file operations.
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: