Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(backend): Remove GH header token middleware #6269

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

amanape
Copy link
Member

@amanape amanape commented Jan 14, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • The middleware messed with the saas /api/github/callback endpoint since it also starts with /api/github. This was only meant to apply to requests under github.py

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below


Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:2f4bb12-nikolaik   --name openhands-app-2f4bb12   docker.all-hands.dev/all-hands-ai/openhands:2f4bb12

@amanape amanape self-assigned this Jan 14, 2025
@amanape amanape enabled auto-merge (squash) January 14, 2025 16:54
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. In either this or a future PR could we add a test to make sure that this doesn't regress?

@amanape amanape merged commit 04382b2 into main Jan 14, 2025
14 checks passed
@amanape amanape deleted the hotfix/gh-callback-bug branch January 14, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants