Optimize Solidity gas use + export js #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds constants to shift gas to deployment
Signed-off-by: zyclonepunch <147099979+zyclonepunch@users.noreply.github.com>
The huff tests revert after you made changes to the huff code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting to know your repo, i noticed a few optimizations that could be made in the solidity code. I am not sure exactly how to access selectors without simply hard coding them in the assembly and that very well may be the best course of action.
I am not sure currently how to update the huff code to pass tests. The Huff and now verification tests all appear to be reverting currently 🥲