Skip to content

Commit

Permalink
add readme content, correct licence and dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
alexey-motorny-amasty committed Nov 25, 2022
1 parent 7ce5576 commit bd7cce7
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Magento\Framework\Data\Collection;

/**
* fix magento issue: https://github.com/magento/magento2/issues/35918
* Correction of strong typing and table prefixes. Our categorical filter can be a multiselect, and therefore we
* always set the array to the filter category, and magneto in this class in the private method
* categoryProductByCustomSortOrder strongly types the value from the filter as int, which causes an error.
Expand Down
18 changes: 17 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
# module-mage-2.4.5-fix
After upgrade Magento to version 2.4.5 you can see this error:
TypeError: Magento\Elasticsearch\Model\ResourceModel\Fulltext\Collection\SearchResultApplier::categoryProductByCustomSortOrder(): Argument #1 ($categoryId) must be of type int, array given


This bug is related to the latest Magento changes and custom extensions like Amasty Improved Layered Navigation.

To see more information

https://github.com/magento/magento2/issues/35918


If you are Amasty customer, you can fix this error by installing additional package from our private repository:

composer require amasty/module-mage-2.4.5-fix


But this case can be reproduced without our extension. This is why we made this package public.
5 changes: 2 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
"require": {
"php": ">=7.3",
"magento/framework": ">=103.0.5",
"magento/module-catalog-inventory": ">=100.4.5",
"amasty/base": ">=1.14.2"
"magento/module-catalog-inventory": ">=100.4.5"
},
"homepage": "https://amasty.com/",
"type": "magento2-module",
"version": "1.0.2",
"license": [
"Commercial"
"proprietary"
],
"autoload": {
"files": [
Expand Down

0 comments on commit bd7cce7

Please sign in to comment.