fix: imporve port management for ios parallel execution (#1470)

AppiumTestDistribution · Dec 12, 2024 · a6992b5 · a6992b5
1 parent 3241411
commit a6992b5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/dashboard-frontend b/dashboard-frontend
diff --git a/src/interfaces/ISessionCapability.ts b/src/interfaces/ISessionCapability.ts
@@ -46,7 +46,7 @@ export type CreateSessionResponseInternal = {
     // session id
     string,
     // capabilities
-    ISessionCapability,
+    Record<string, any>,
     // protocol
     string?,
   ];
@@ -55,7 +55,7 @@ export type CreateSessionResponseInternal = {
 export type W3CNewSessionResponse = {
   value: {
     sessionId: string;
-    capabilities: ISessionCapability;
+    capabilities: Record<string, any>;
   };
 };
 

diff --git a/src/modules b/src/modules
diff --git a/src/plugin.ts b/src/plugin.ts
@@ -477,17 +477,24 @@ class DevicePlugin extends BasePlugin {
     caps: ISessionCapability,
   ): Promise<CreateSessionResponseInternal | Error> {
     const remoteUrl = `${nodeUrl(device, DevicePlugin.nodeBasePath)}/session`;
-    let capabilitiesToCreateSession = { capabilities: caps };
+    const capabilitiesToCreateSession = { capabilities: caps };
 
     if (device.hasOwnProperty('cloud') && device.cloud.toLowerCase() === Cloud.LAMBDATEST) {
-      if(capabilitiesToCreateSession.capabilities.alwaysMatch && Object.keys(capabilitiesToCreateSession.capabilities.alwaysMatch).length == 0) {
+      if (
+        capabilitiesToCreateSession.capabilities.alwaysMatch &&
+        Object.keys(capabilitiesToCreateSession.capabilities.alwaysMatch).length == 0
+      ) {
         delete capabilitiesToCreateSession.capabilities.alwaysMatch;
       }
-      if(capabilitiesToCreateSession.capabilities.firstMatch && 
-        _.isArray(capabilitiesToCreateSession.capabilities.firstMatch) && 
-        (!capabilitiesToCreateSession.capabilities.firstMatch.length || 
-          capabilitiesToCreateSession.capabilities.firstMatch.every(m => Object.keys(m).length ==0 ))) {
-            //@ts-ignore
+      if (
+        capabilitiesToCreateSession.capabilities.firstMatch &&
+        _.isArray(capabilitiesToCreateSession.capabilities.firstMatch) &&
+        (!capabilitiesToCreateSession.capabilities.firstMatch.length ||
+          capabilitiesToCreateSession.capabilities.firstMatch.every(
+            (m) => Object.keys(m).length == 0,
+          ))
+      ) {
+        //@ts-ignore
         delete capabilitiesToCreateSession.capabilities.firstMatch;
       }
     }