Make with: type more permissive (#8)

ArmaanT · Jan 11, 2021 · 7722609 · 7722609
1 parent eb871b5
commit 7722609
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/packages/cdkactions/src/job.ts b/packages/cdkactions/src/job.ts
@@ -86,7 +86,7 @@ export interface StepsProps extends RunProps {
   /**
    * A map of parameters for an external action.
    */
-  readonly with?: StringMap;
+  readonly with?: { [key: string]: string | number | boolean };
 
   /**
    * Additional environment variables.

diff --git a/packages/cdkactions/test/__snapshots__/job.test.ts.snap b/packages/cdkactions/test/__snapshots__/job.test.ts.snap
@@ -11,6 +11,15 @@ Object {
       "timeout-minutes": 5,
       "working-directory": "~/",
     },
+    Object {
+      "name": "External action",
+      "uses": "actions/checkout@v2",
+      "with": Object {
+        "booleanValue": false,
+        "numberValue": 10,
+        "stringValue": "string",
+      },
+    },
   ],
   "strategy": Object {
     "fail-fast": true,

diff --git a/packages/cdkactions/test/job.test.ts b/packages/cdkactions/test/job.test.ts
@@ -14,6 +14,15 @@ test('toGHAction', () => {
       continueOnError: false,
       timeoutMinutes: 5,
       workingDirectory: '~/',
+    },
+    {
+      name: 'External action',
+      uses: 'actions/checkout@v2',
+      with: {
+        stringValue: 'string',
+        numberValue: 10,
+        booleanValue: false,
+      },
     }],
   });
   expect(job.toGHAction()).toMatchSnapshot();