Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 98: Comment reply to entries #103

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Issue 98: Comment reply to entries #103

wants to merge 13 commits into from

Conversation

westonruter
Copy link
Contributor

Fixes #98

screen_shot_2013-07-09_at_2 23 24_am

@westonruter
Add inline comments for liveblog comments
94958de 
Comments have liveblog comment persisted with some hackery as otherwise
WordPress sets the comment_parent to 0 since it is not a recognized status.

Still needing to render the comments under the liveblog comment parents.
@westonruter
Filter liveblog comment_link with proper target
e3bc946 
Store element ID base in constant and export to JS
@westonruter
Set liveblog reply comment type
5186011
@westonruter
Fix jshint error wrt undeclared addComment global
641e68a
@westonruter
Associate comment replies with their liveblog parent comments
3f6d2a6
@westonruter
Update entry template to render reply comments
3486686
@westonruter
Copy link
Contributor Author

@mjangda reply comments are now rendered in the template. Screenshots are from Chrome which supports the details element:

comment replies collapsed

comment replies displayed

@mjangda
Copy link
Member

mjangda commented Jul 11, 2013

Question: Will comment replies be streamed in as they get added just like the author's liveblog comments? Or will new comments only be updated as the page reloads? I assume the former.

Ideally, the former.

Question: Will the user comments be hidden by default with a link to expand them?

Yep, the focus should continue to be on the liveblog entries but let users interact with comments as they like.

Question: Should the comment replies be nestable? Or should they only be able to have the liveblog comment as their only possible parent?

Sure, if that's easy enough to do, but not necessary.

@westonruter
Copy link
Contributor Author

@mjangda thanks for the feedback.

Regarding streaming of comments, I believe actually this increases the scope of the issue. So for now comments will only be updated when the page reloads (or, incidentally, if a liveblog gets edited).

And the user comment replies will be collapsed by default, as I noted above with screenshots. If the user has a permalink to a liveblog comment in a collapsed container (e.g. if they submitted a new comment), the container will automatically expand upon page load.

And lastly, supporting threaded/nested liveblog reply comments is possible, but I believe it also out of scope of this issue.

Ready for review.

@mjangda
Copy link
Member

mjangda commented Jul 11, 2013

Yep, makes sense re: scope.

westonruter
westonruter reviewed Aug 2, 2013
View reviewed changes
liveblog.php
* @see self::fixup_comment_parent()
* @filter preprocess_comment
*/
public static function save_original_comment_parent_for_fixup( $commentdata ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjangda I've submitted a core patch to add a wp_insert_comment_data filter: http://core.trac.wordpress.org/ticket/23931#comment:2

@henrywright
Copy link

This is super cool!

I've tested this in Chrome and thought I'd give some feedback:

  1. On clicking Edit in a comment, you are taken to the WP dashboard. This is unlike editing an entry, where you are able to remain on the liveblog page and make the edit.
  2. Posting a comment reloads the page, unlike posting an entry which does not require a page reload.
  3. The comment date is absolute (24 Feb 2014) where as entry dates are relative (8 hours ago).
  4. In order to enable liveblog entry commenting, you have to enable editing on the post which causes the standard comment form to appear after the very last entry. I'm not sure if there is a need to display that form?
  5. Comments are added to the page only after a manual page reload. This is unlike entries which are added to the page without the need for a page refresh.
  6. Comments under each entry seem to be in an numbered list with the most recent comment show first. E.G. 1. Fifth comment 2. Fourth comment 3 Third comment 4 Second comment 5 First comment. Looks slightly confusing. Perhaps a bulleted list would work better?

Hopefully my observations help. Looking forward to this becoming available by the way - it adds a whole new level of interactivity to liveblogs!

@henrywright
Copy link

Some more feedback on this after testing in IE:

  1. The details tag isn't supported by early versions of IE. This results in the comments being always hidden when using that (annoying) browser.

cain pushed a commit to cain/liveblog that referenced this pull request Sep 25, 2018
Merge pull request Automattic#103 in SPP/plugin-liveblogging from bun…
884ce5e 
…dle-size to master

* commit '8b3d09bb1493d870d2a8bc0d9b31dbf4ab954e63':
  webpack remove vendor file from build
  remove vendor file
  Cleanup rxjs import
  dynamic webpack chunk loading
  code splitting editorcontainer, react-loadable, es2015
  [WIP] Cleanup build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment reply to entries
5 participants
@westonruter @mjangda @henrywright @GaryJones @philipjohn