disable wip test

AvaProtocol · Dec 27, 2024 · ed4aa3e · ed4aa3e
1 parent b31ab79
commit ed4aa3e
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 39 deletions.
diff --git a/core/taskengine/macros/exp.go b/core/taskengine/macros/exp.go
@@ -158,8 +158,10 @@ func (bi *Builtin) ParseUnit(val string, decimal uint) *big.Int {
 
 var (
 	exprEnv = map[string]any{
-		"fetch":            Fetch,
-		"request":          Fetch,
+		// bind and simular JS fetch api
+		"fetch": Fetch,
+
+		// macro to do IO from JS
 		"readContractData": readContractData,
 
 		"priceChainlink":           chainlinkLatestAnswer,
@@ -193,7 +195,6 @@ type FetchOptions struct {
 func Fetch(url string) *FetchResponse {
 	options := FetchOptions{}
 
-	fmt.Println("FETCH", url)
 	client := resty.New()
 	// Create request
 	request := client.R()

diff --git a/core/taskengine/vm_runner_customcode.go b/core/taskengine/vm_runner_customcode.go
@@ -25,10 +25,11 @@ func NewJSProcessor(vm *VM) *JSProcessor {
 		jsvm: goja.New(),
 	}
 
+	// These are built-in func
 	for key, value := range macros.GetEnvs(nil) {
-		fmt.Println("Set", key)
 		r.jsvm.Set(key, value)
 	}
+	/// Binding the data from previous step into jsvm
 	for key, value := range vm.vars {
 		r.jsvm.Set(key, map[string]any{
 			"data": value,

diff --git a/core/taskengine/vm_runner_customcode_test.go b/core/taskengine/vm_runner_customcode_test.go
@@ -1,7 +1,6 @@
 package taskengine
 
 import (
-	"fmt"
 	"strings"
 	"testing"
 
@@ -89,37 +88,38 @@ func TestRunJavaScriptComplex(t *testing.T) {
 	}
 }
 
-func TestRunJavaScriptHTTP(t *testing.T) {
-	node := &avsproto.CustomCodeNode{
-		Source: `
-		toBigInt("1234442")
-		`,
-	}
-	nodes := []*avsproto.TaskNode{
-		&avsproto.TaskNode{
-			Id:   "123abc",
-			Name: "customJs",
-			TaskType: &avsproto.TaskNode_CustomCode{
-				CustomCode: node,
-			},
-		},
-	}
-
-	edges := []*avsproto.TaskEdge{
-		&avsproto.TaskEdge{
-			Id:     "e1",
-			Source: "__TRIGGER__",
-			Target: "123abc",
-		},
-	}
-
-	vm, _ := NewVMWithData("123abc", nil, nodes, edges)
-	n := NewJSProcessor(vm)
-
-	step, err := n.Execute("123abc", node)
-	fmt.Println("error", err, step.OutputData)
-
-	if step.OutputData != "[2,3]" {
-		t.Errorf("wrong JS code evaluation result, expect [2,3] got %s", step.OutputData)
-	}
-}
+// Temp disable until we figured out the event loop
+// func TestRunJavaScriptHTTP(t *testing.T) {
+// 	node := &avsproto.CustomCodeNode{
+// 		Source: `
+// 		toBigInt("1234442")
+// 		`,
+// 	}
+// 	nodes := []*avsproto.TaskNode{
+// 		&avsproto.TaskNode{
+// 			Id:   "123abc",
+// 			Name: "customJs",
+// 			TaskType: &avsproto.TaskNode_CustomCode{
+// 				CustomCode: node,
+// 			},
+// 		},
+// 	}
+//
+// 	edges := []*avsproto.TaskEdge{
+// 		&avsproto.TaskEdge{
+// 			Id:     "e1",
+// 			Source: "__TRIGGER__",
+// 			Target: "123abc",
+// 		},
+// 	}
+//
+// 	vm, _ := NewVMWithData("123abc", nil, nodes, edges)
+// 	n := NewJSProcessor(vm)
+//
+// 	step, err := n.Execute("123abc", node)
+// 	fmt.Println("error", err, step.OutputData)
+//
+// 	if step.OutputData != "[2,3]" {
+// 		t.Errorf("wrong JS code evaluation result, expect [2,3] got %s", step.OutputData)
+// 	}
+// }